WIP: Multipart index single field query #169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expected that {0, 1}, {0, 2} will be returned. But rowset is
empty.
olegrok
force-pushed
the
multipart-index-single-field-query
branch
from
7cfdb86 to
c64ffa8
Compare
olegrok
force-pushed
the
multipart-index-single-field-query
branch
from
c64ffa8 to
862906c
Compare
olegrok
commented
Jun 15, 2021
Comment on lines
-56
to
-61
| local cmp_operator = select_comparators.get_cmp_operator(opts.tarantool_iter) | ||
| local scan_comparator = select_comparators.gen_tuples_comparator(cmp_operator, index.parts) | ||
| local after_tuple_key = utils.extract_key(opts.after_tuple, index.parts) | ||
| if scan_comparator(after_tuple_key, opts.scan_value) then | ||
| value = after_tuple_key | ||
| end |
There was a problem hiding this comment.
Actually after this change scroll_to_after_tuple makes fullscan. So funny that our tests don't catch it.
|
Will be fixed in #177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only tests from this patch have value. This patch can't be merged as is because introduces performance degradation.